Re: [PATCH 4/5] git-log.txt: rewrite note on why "--" may be required

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 4/5] git-log.txt: rewrite note on why "--" may be required

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:56

Junio C Hamano [off-list ref] writes:
Ramkumar Ramachandra [off-list ref] writes:
quoted
Junio C Hamano wrote:
quoted
I think "branch names" was an attempt to make it more newbie
friendly by sacrificing technical accuracy.  With the suggested
update (see the review for the previous one), it would be easier to
read if this part said "options or the revision range".
Why does it have to be a range? It might well be a list of revisions,
Study "Specifying Ranges" section of gitrevisions and come back,
perhaps?
A bit more specifically, there is a reason why we list "Specifying
Revisions" and "Specifying Ranges" separately in that manual page.

I think you are trying explain "git log --short A B ^C" as if it
takes "--short" (which is an option), "A", "B", and "^C" (all of
which are revisions).  And I am saying that is wrong.

It is "--short" (which is an option) and "A B ^C" (which is a
revision range).

"git log --short A" is taking "--short" (an option) and "A".  This
"A" is still a revision range and not a single revision.  It is a
single commit that is used to name a revision range which is the
entire history behind the commit "A".

Re: [PATCH 4/5] git-log.txt: rewrite note on why "--" may be required

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:56:56

Junio C Hamano wrote:
I think you are trying explain "git log --short A B ^C" as if it
takes "--short" (which is an option), "A", "B", and "^C" (all of
which are revisions).  And I am saying that is wrong.

It is "--short" (which is an option) and "A B ^C" (which is a
revision range).
Got it.  Your explanation makes more sense.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help