Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:55

Johannes Sixt [off-list ref] writes:
quoted
But I think it can be useful outside the context of send-email as
well, and having one independent tool that does one single job well
is a better design.  Perhaps it is better to name it less specific
to send-email's cc-cmd option.  "git people"?  "git whom"?  "git
reviewers"?  I dunno, but along those lines.
Would it make sense to integrate this in git shortlog, which already
does something similar?
Conceptually, yes, but the end result will be much larger in scope.
I am not sure if "shortlog" is still a good label for it.

"shortlog", when it internally runs "log" [*1*], is still about the
commits within the range given to the command; "shortlog A..B" talks
only about commits within A..B range.  This new thing is about what
happened to the part of the code A..B touches in the past
(i.e. before A happened), which feels a bit different.


[Footnote]

*1* It can be used as a filter to "git log" output, which is a bit
    different animal, but it still is about shortening that incoming
    log, not about independently digging the history using the input
    as a starting point.

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

From: Jeremy Rosen <hidden>
Date: 2016-06-15 22:56:56

quoted
Would it make sense to integrate this in git shortlog, which
already
does something similar?
Conceptually, yes, but the end result will be much larger in scope.
I am not sure if "shortlog" is still a good label for it.
since we are throwing ideas around...

The first place where I would logically look for such a feature would be
in git-blame --cc-list or something like that.

git-blame seems to me as a logical place for all "look at history and give
me a list of names" type commands
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help