Re: git-archive --worktree-attributes (1.8.2)

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: git-archive --worktree-attributes (1.8.2)

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:45

Amit Bakshi [off-list ref] writes:
Hi,

 In the help for git-archive it states:

       --worktree-attributes
           Look for attributes in .gitattributes in working directory too.
...
The worktree-attributes should read from the worktree.  It should
not pay any attention to where you are in the directory hierarchy,
i.e. your current working directory (aka $cwd).
Would you accept a patch that either adds an option to explicitly set
the .gitattributes file or would let --worktree-attributes look in
$PWD.
The former, possibly, if accompanied with a good justification and
implemented cleanly.

The latter, definitely not.

[PATCH] archive: clarify explanation of --worktree-attributes

From: René Scharfe <hidden>
Date: 2016-06-15 22:56:45

Make it a bit clearer that --worktree-attributes is about files in the
working tree (checked out files, possibly changed) and not the current
working directory ($PDW).  Link to the ATTRIBUTES section, which has
more details.

Reported-by: Amit Bakshi <redacted>
Signed-off-by: Rene Scharfe <redacted>
---
Does this help a bit?

 Documentation/git-archive.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-archive.txt b/Documentation/git-archive.txt
index b4c2e24..3dd3069 100644
--- a/Documentation/git-archive.txt
+++ b/Documentation/git-archive.txt
@@ -56,7 +56,8 @@ OPTIONS
 	Write the archive to <file> instead of stdout.
 
 --worktree-attributes::
-	Look for attributes in .gitattributes in working directory too.
+	Look for attributes in .gitattributes files in the working tree
+	as well (see <<ATTRIBUTES>>).
 
 <extra>::
 	This can be any options that the archiver backend understands.
-- 
1.8.2.1

Re: [PATCH] archive: clarify explanation of --worktree-attributes

From: Eric Sunshine <hidden>
Date: 2016-06-15 22:56:45

On Wed, Apr 10, 2013 at 1:49 PM, René Scharfe
[off-list ref] wrote:
Make it a bit clearer that --worktree-attributes is about files in the
working tree (checked out files, possibly changed) and not the current
working directory ($PDW).  Link to the ATTRIBUTES section, which has
s/PDW/PWD/
more details.

Reported-by: Amit Bakshi <redacted>
Signed-off-by: Rene Scharfe <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help