Re: [PATCH v2 2/2] submodule: drop the top-level requirement

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v2 2/2] submodule: drop the top-level requirement

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:45

John Keeping [off-list ref] writes:
+	eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")"
This may be handier than having to do the "for arg" loop git-am uses
yourself.
quoted hunk
 	(
 		git ls-files --error-unmatch --stage -- "$@" ||
 		echo "unmatched pathspec exists"
@@ -335,6 +339,8 @@ cmd_add()
 		usage
 	fi
 
+	sm_path="$wt_prefix$sm_path"
But this is doing fine without "rev-parse --prefix" at all.

Re: [PATCH v2 2/2] submodule: drop the top-level requirement

From: John Keeping <hidden>
Date: 2016-06-15 22:56:45

On Tue, Apr 09, 2013 at 02:00:52PM -0700, Junio C Hamano wrote:
John Keeping [off-list ref] writes:
quoted
+	eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")"
This may be handier than having to do the "for arg" loop git-am uses
yourself.
quoted
 	(
 		git ls-files --error-unmatch --stage -- "$@" ||
 		echo "unmatched pathspec exists"
@@ -335,6 +339,8 @@ cmd_add()
 		usage
 	fi
 
+	sm_path="$wt_prefix$sm_path"
But this is doing fine without "rev-parse --prefix" at all.
In this case we only have a single argument (and it must have a value).
In the cases using "rev-parse --prefix" we can have any number of
arguments (including zero).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help