DORMANTno replies

[PATCH V2] remote-helpers/test-bzr.sh: do not use grep \s

From: Torsten Bögershausen <hidden>
Date: 2016-06-15 22:56:43
Subsystem: the rest · Maintainer: Linus Torvalds

Using grep "devel\s\+3:" to find at least one whitespace
is not portable on all grep versions:
Not all grep versions understand "\s" as a "whitespace".

The + as a qualifier for "one or more" is not a basic regular expression:
use egrep instead of grep.
Use a literal TAB followed by SPACE like this [	 ] instead,
which is more portable than [:space:] 

Signed-off-by: Torsten Bögershausen <redacted>
---
 contrib/remote-helpers/test-hg.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh
index 5f81dfa..7bb81f2 100755
--- a/contrib/remote-helpers/test-hg.sh
+++ b/contrib/remote-helpers/test-hg.sh
@@ -115,7 +115,7 @@ test_expect_success 'update bookmark' '
   git push
   ) &&
 
-  hg -R hgrepo bookmarks | grep "devel\s\+3:"
+  hg -R hgrepo bookmarks | egrep "devel[	 ]+3:"
 '
 
 test_done
-- 
1.8.2.341.g543621f
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help