Re: fetch --no-tags with and w/o --all

Jeff King [off-list ref] writes:

On Wed, Mar 06, 2013 at 01:56:01PM -0800, Junio C Hamano wrote:

quoted

Cristian Tibirna [off-list ref] writes:

quoted

Hello

$ git --version
git version 1.7.10.4

$ git fetch origin --no-tags
does what it says

$ git fetch --all --no-tags
still gets all the tags from the remote.

Is this known?

Because --all (or --multiple) to iterate through all remotes
does not pass accept any command line refspecs, using these options
with --no-tags and/or --tags should be diagnosed as an error, but it
appears that the error checking is not done.

Or we could just pass them through. Looks like this was already fixed by
8556646 (fetch --all: pass --tags/--no-tags through to each remote,
2012-09-05), which is in v1.7.12.2 and higher.

;-)  No wonder this looked somewhat familiar.

On Wed, Mar 06, 2013 at 04:41:44PM -0800, Junio C Hamano wrote:

quoted

Or we could just pass them through. Looks like this was already fixed by
8556646 (fetch --all: pass --tags/--no-tags through to each remote,
2012-09-05), which is in v1.7.12.2 and higher.

;-)  No wonder this looked somewhat familiar.

I still find it somewhat gross that we actually re-construct the
command-line from the parsed flag variables. It seems like it would be
easier to simply propagate the argv we got in the first place, and then
we would not have any chance of omitting a new option that is added
later.

Probably not worth worrying about now, though, as the fix is long since
shipped.  The next person who is adding an option can look at doing that
refactoring. And it may be that there are some options we don't
propagate intentionally (I didn't look closely).

-Peff