Re: [PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:56:05

Jeff King [off-list ref] writes:
That seems much cleaner to me. If done right, it could also let people
put:

  CONTRIB_PERL += contrib/mw-to-git/git-remote-mediawiki
Actually, you can already do this:

  SCRIPT_PERL += contrib/mw-to-git/git-remote-mediawiki.perl

probably not by design, but it works!

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Re: [PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script

From: Jeff King <hidden>
Date: 2016-06-15 22:56:05

On Fri, Feb 08, 2013 at 06:34:37PM +0100, Matthieu Moy wrote:
Jeff King [off-list ref] writes:
quoted
That seems much cleaner to me. If done right, it could also let people
put:

  CONTRIB_PERL += contrib/mw-to-git/git-remote-mediawiki
Actually, you can already do this:

  SCRIPT_PERL += contrib/mw-to-git/git-remote-mediawiki.perl

probably not by design, but it works!
So putting:

  ROOT=contrib/mw-to-git
  git-remote-mediawiki: FORCE
          @make -C ../.. SCRIPT_PERL=$(ROOT)/$@.perl $(ROOT)/$@

in contrib/mw-to-git/Makefile would already work? Neat.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help