Brandon Casey [off-list ref] writes:
On Fri, Jan 18, 2013 at 7:02 AM, Andreas Schwab [off-list ref] wrote:
quoted
Brandon Casey [off-list ref] writes:
quoted
+ array[$(($#array+1))]="$c"
You don't need $(( )) since the array index is already evaluated as an
arithmethic expression.
Ah, I didn't know that. Thanks.
I think Junio will probably fix this up if he thinks it's worth it,
but I can resubmit if necessary.
Please; I do not have mental bandwidth to keep track of contrib/
material myself.
On Fri, Jan 18, 2013 at 11:08 AM, Junio C Hamano [off-list ref] wrote:
Brandon Casey [off-list ref] writes:
quoted
On Fri, Jan 18, 2013 at 7:02 AM, Andreas Schwab [off-list ref] wrote:
quoted
Brandon Casey [off-list ref] writes:
quoted
+ array[$(($#array+1))]="$c"
You don't need $(( )) since the array index is already evaluated as an
arithmethic expression.
Ah, I didn't know that. Thanks.
I think Junio will probably fix this up if he thinks it's worth it,
but I can resubmit if necessary.
Please; I do not have mental bandwidth to keep track of contrib/
material myself.
No problem.
-Brandon
When commit d8b45314 began separating the zsh completion from the bash
completion, it introduced a zsh completion "bridge" section into the bash
completion script for zsh users to use until they migrated to the zsh
script. The zsh '+=()' append-to-array notation prevents bash 3.00.15 on
CentOS 4.x from loading the completion script and breaks test 9902. We can
easily work around this by using standard Bash array notation.
Signed-off-by: Brandon Casey <redacted>
---
On Fri, Jan 18, 2013 at 7:02 AM, Andreas Schwab [off-list ref] wrote:
Brandon Casey [off-list ref] writes:
quoted
+ array[$(($#array+1))]="$c"
You don't need $(( )) since the array index is already evaluated as an
arithmethic expression.
Fixed.
-Brandon
contrib/completion/git-completion.bash | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index a4c48e1..2f99420 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2431,7 +2431,7 @@ if [[ -n ${ZSH_VERSION-} ]]; then
--*=*|*.) ;;
*) c="$c " ;;
esac
- array+=("$c")
+ array[$#array+1]="$c"
done
compset -P '*[=:]'
compadd -Q -S '' -p "${2-}" -a -- array && _ret=0--
1.7.8.4
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------