Bug in latest gitk - can't click lines connecting commits

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Bug in latest gitk - can't click lines connecting commits

From: Jason Holden <hidden>
Date: 2016-06-15 22:55:37

I was testing some patches against the latest gitk, and noticed that when I 
click the mouse on the lines that connect the commits in the history graph,
I get an error popup with:
 Error: can't read "cflist_top": no such variable

Looks like this was introduced in gitk commit b967135d89e8d8461d059
 gitk: Synchronize highlighting in file view when scrolling diff

This commit hasn't been merged yet from upstream into git.

Here's the full error trace:
can't read "cflist_top": no such variable
can't read "cflist_top": no such variable
    while executing
"$cflist tag remove highlight $cflist_top.0 "$cflist_top.0 lineend""
    (procedure "highlightfile" line 4)
    invoked from within
"highlightfile 0"
    (procedure "highlightfile_for_scrollpos" line 8)
    invoked from within
"highlightfile_for_scrollpos $topidx"
    (procedure "scrolltext" line 9)
    invoked from within
"scrolltext 0.0 1.0"
    (vertical scrolling command executed by text)

-Jason

Re: Bug in latest gitk - can't click lines connecting commits

From: Stefan Haller <hidden>
Date: 2016-06-15 22:55:37

Jason Holden [off-list ref] wrote:
I was testing some patches against the latest gitk, and noticed that when I
click the mouse on the lines that connect the commits in the history graph,
I get an error popup with:
 Error: can't read "cflist_top": no such variable

Looks like this was introduced in gitk commit b967135d89e8d8461d059
 gitk: Synchronize highlighting in file view when scrolling diff
A patch that fixes this was proposed over two months ago, and Paul said
he had applied it:

  <http://permalink.gmane.org/gmane.comp.version-control.git/208162>

However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.
Paul?


-- 
Stefan Haller
Berlin, Germany
http://www.haller-berlin.de/

Re: Bug in latest gitk - can't click lines connecting commits

From: Paul Mackerras <hidden>
Date: 2016-06-15 22:55:38

On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote:
Jason Holden [off-list ref] wrote:
quoted
I was testing some patches against the latest gitk, and noticed that when I
click the mouse on the lines that connect the commits in the history graph,
I get an error popup with:
 Error: can't read "cflist_top": no such variable

Looks like this was introduced in gitk commit b967135d89e8d8461d059
 gitk: Synchronize highlighting in file view when scrolling diff
A patch that fixes this was proposed over two months ago, and Paul said
he had applied it:

  <http://permalink.gmane.org/gmane.comp.version-control.git/208162>

However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.
Paul?
I just forgot to push it out.  It's there now.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help