Nguyen Thai Ngoc Duy [off-list ref] writes:
On Sat, Dec 8, 2012 at 12:59 AM, Junio C Hamano [off-list ref] wrote:
quoted
quoted
* If somebody has a working replacement URL, we could use that
instead, of course. Takers?
A possible alternative could be https://www.ohloh.net/p/git/contributors/summary
Nice charts!
Yup.
Their numbers seem to be just 'any commit by the author, with
mailmap applied', and I am of two minds with it. Counting without
"shortlog --no-merges", depending on the management style of the
project, tends to credit the integrator too much. Even though
vetting the patches and choosing when to merge the topics is a
significant contribution, it isn't *that* big compared to the work
done by the contributor who took initiative to scratch that itch.
With or without "--no-merges", the big picture you can get out of
"git shortlog -s -n --since=1.year" does not change very much, but
the headline numbers give a wrong impression.
And of course, application of the mailmap is very important, if you
want to get meaningful numbers out of shortlog over a longer period.
On Mon, Dec 10, 2012 at 1:31 PM, Junio C Hamano [off-list ref] wrote:
Nguyen Thai Ngoc Duy [off-list ref] writes:
quoted
On Sat, Dec 8, 2012 at 12:59 AM, Junio C Hamano [off-list ref] wrote:
quoted
quoted
* If somebody has a working replacement URL, we could use that
instead, of course. Takers?
A possible alternative could be https://www.ohloh.net/p/git/contributors/summary
Nice charts!
Yup.
Their numbers seem to be just 'any commit by the author, with
mailmap applied', and I am of two minds with it. Counting without
"shortlog --no-merges", depending on the management style of the
project, tends to credit the integrator too much. Even though
vetting the patches and choosing when to merge the topics is a
significant contribution, it isn't *that* big compared to the work
done by the contributor who took initiative to scratch that itch.
With or without "--no-merges", the big picture you can get out of
"git shortlog -s -n --since=1.year" does not change very much, but
the headline numbers give a wrong impression.
These numbers are approximate anyway. Commit counts or the number of
changed lines do not accurately reflect the effort in many cases. And
about merges, in this particular case of Git where the maintainer imo
has done an excellent job as a guard, I'd say it's the credit for
reviewing, not simply merging.
But not using the link is fine too. We can wait for Jeff's patch to be merged.
And of course, application of the mailmap is very important, if you
want to get meaningful numbers out of shortlog over a longer period.
--
Duy
On Mon, Dec 10, 2012 at 07:04:40PM +0700, Nguyen Thai Ngoc Duy wrote:
quoted
With or without "--no-merges", the big picture you can get out of
"git shortlog -s -n --since=1.year" does not change very much, but
the headline numbers give a wrong impression.
These numbers are approximate anyway. Commit counts or the number of
changed lines do not accurately reflect the effort in many cases. And
about merges, in this particular case of Git where the maintainer imo
has done an excellent job as a guard, I'd say it's the credit for
reviewing, not simply merging.
I agree that commit count is approximate. But counting merges is really
quite a large factor of error (in git.git, it more than doubles Junio's
count, and represents over 20% of the total number of commits).
The GitHub contributors page counts merges _and_ fails to use mailmap.
Yuck. I'm working on fixing that now.
But not using the link is fine too. We can wait for Jeff's patch to be
merged.
After the discussion in the PR, I am inclined to think the site (and
possibly the manpage) should just point to some decent contributors
graph (either GitHub, ohloh, or something else; suggestions welcome).
Anything else is just recreating a crappy static version of something
that could be much more dynamic and explorable.
I find the ohloh one a little more informative than the GitHub graph. I
couldn't find any others (Google Code does not seem to have one,
kernel.org and other gitweb sites do not, and I can't think of anywhere
else that hosts a mirror).
-Peff