Re: [PATCH 6/8] imap-send: change msg_data from storing (char *, len) to storing strbuf
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:28
Michael Haggerty [off-list ref] writes:
On 11/29/2012 10:30 PM, Junio C Hamano wrote:quoted
quoted
A side effect of this change is that the memory for each message is freed after it is used rather than leaked, though that detail is unimportant given that imap-send is a top-level command. --?If by "?" you are wondering where the memory leak was, it was:
No, I was wondering if you meant to say "---" to mark te remainder of what you wrote does not exactly belong to the log message.
quoted
quoted
For some reason, there is a bunch of infrastructure in this file for dealing with IMAP flags, although there is nothing in the code that actually allows any flags to be set. If there is no plan to add support for flags in the future, a bunch of code could be ripped out and "struct msg_data" could be completely replaced with strbuf.Yeah, after all these years we have kept the unused flags field there and nobody needed anything out of it. I am OK with a removal if it is done at the very end of the series.I don't think the removal of flags needs to be part of the same series.
Oh, I did not think so, either.
I suggest a separate patch series dedicated to deleting *all* the extra imap infrastructure at once. That being said, I'm not committing to do so. (We could add it to an "straightforward projects for aspiring git developers" list, if we had such a thing.)
A "low-hanging fruit and/or janitorial work" stack may be worth having.