[PATCH] t0003-attributes.sh: Don't overwrite t/.gitattributes

Subsystems: the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] t0003-attributes.sh: Don't overwrite t/.gitattributes

From: Ramsay Jones <hidden>
Date: 2016-06-15 22:55:00

Signed-off-by: Ramsay Jones <redacted>
---

Hi Junio,

This test in the current pu branch (commit bb0e6bf "Merge branch
'aw/rebase-am-failure-detection' into pu", 11-10-2012) overwrites
the contents of t/.gitattributes. Note that the merge of the two
branches 'nd/wildmatch' and 'nd/attr-match-optim-more' both add
new tests at the end, and *both* sets initially 'cd ..' ...

ATB,
Ramsay Jones

 t/t0003-attributes.sh | 1 -
 1 file changed, 1 deletion(-)
diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh
index 7ed288f..fe80af7 100755
--- a/t/t0003-attributes.sh
+++ b/t/t0003-attributes.sh
@@ -247,7 +247,6 @@ test_expect_success 'patterns starting with exclamation' '
 '
 
 test_expect_success '"**" test' '
-	cd .. &&
 	echo "**/f foo=bar" >.gitattributes &&
 	cat <<\EOF >expect &&
 f: foo: bar
-- 
1.7.12

Re: [PATCH] t0003-attributes.sh: Don't overwrite t/.gitattributes

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:55:00

On Sun, Oct 14, 2012 at 12:44 AM, Ramsay Jones
[off-list ref] wrote:
Signed-off-by: Ramsay Jones <redacted>
---

Hi Junio,

This test in the current pu branch (commit bb0e6bf "Merge branch
'aw/rebase-am-failure-detection' into pu", 11-10-2012) overwrites
the contents of t/.gitattributes. Note that the merge of the two
branches 'nd/wildmatch' and 'nd/attr-match-optim-more' both add
new tests at the end, and *both* sets initially 'cd ..' ...
I'm resending nd/wildmatch to move the tests before bare repo tests so
"cd .." is no longer necessary. nd/attr-match-optim-more has the same
fix.
quoted hunk
 t/t0003-attributes.sh | 1 -
 1 file changed, 1 deletion(-)
diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh
index 7ed288f..fe80af7 100755
--- a/t/t0003-attributes.sh
+++ b/t/t0003-attributes.sh
@@ -247,7 +247,6 @@ test_expect_success 'patterns starting with exclamation' '
 '

 test_expect_success '"**" test' '
-       cd .. &&
        echo "**/f foo=bar" >.gitattributes &&
        cat <<\EOF >expect &&
 f: foo: bar
--
1.7.12


-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help