From: Junio C Hamano <hidden> Date: 2016-06-15 22:54:57
Ramsay Jones [off-list ref] writes:
The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
variable, either from the environment or command line of an
'make test' invocation. In order to allow the malloc checks to be
disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
to the environment using an export directive.
We would want to encourage people to test with cheap but effective
checks when available. I do not see "malloc: using debugging hooks"
message anywhere when I run tests, but if you do, I'd rather see us
check if we can tell glibc to stop doing so first without disabling
the whole test. Your patch feels like the first step to a slipperly
slope whose destination would make us say "we get too many messages
so let's do nothing in "make test" with this configuration." when
taken to the extreme, and obviously we would not want to go there
;-).
Elia, you brought the MALLOC_CHECK_ up. Did you hear about this
issue elsewhere before, and if you did, do you know how other
projects solves it?
Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK
to your environment before running "make test" suffice?
Hi Julio.
No, i don't know this message before. Difficult that can be related to
a recent glibc change, i think. Perhaps eglibc ? I tomorrow take a
look, i am on travel now.
Best
2012/10/6, Junio C Hamano [off-list ref]:
Ramsay Jones [off-list ref] writes:
quoted
The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
variable, either from the environment or command line of an
'make test' invocation. In order to allow the malloc checks to be
disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
to the environment using an export directive.
We would want to encourage people to test with cheap but effective
checks when available. I do not see "malloc: using debugging hooks"
message anywhere when I run tests, but if you do, I'd rather see us
check if we can tell glibc to stop doing so first without disabling
the whole test. Your patch feels like the first step to a slipperly
slope whose destination would make us say "we get too many messages
so let's do nothing in "make test" with this configuration." when
taken to the extreme, and obviously we would not want to go there
;-).
Elia, you brought the MALLOC_CHECK_ up. Did you hear about this
issue elsewhere before, and if you did, do you know how other
projects solves it?
Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK
to your environment before running "make test" suffice?
The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
variable, either from the environment or command line of an
'make test' invocation. In order to allow the malloc checks to be
disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
to the environment using an export directive.
We would want to encourage people to test with cheap but effective
checks when available. I do not see "malloc: using debugging hooks"
message anywhere when I run tests, but if you do, I'd rather see us
check if we can tell glibc to stop doing so first without disabling
the whole test. Your patch feels like the first step to a slipperly
slope whose destination would make us say "we get too many messages
so let's do nothing in "make test" with this configuration." when
taken to the extreme, and obviously we would not want to go there
;-).
Elia, you brought the MALLOC_CHECK_ up. Did you hear about this
issue elsewhere before, and if you did, do you know how other
projects solves it?
Ok. I have found. For me this is not a problem any more these days.
Was fixed in glibc 2.8.90-9 2008
* Wed Jul 16 2008 Jakub Jelinek [off-list ref] 2.8.90-9
- update from trunk
- fix unbuffered vfprintf if writing to the stream fails (#455360)
- remove useless "malloc: using debugging hooks" message (#455355)
- nscd fixes
(from glibc rpm changelog)
This is the bugzilla filled and closed
https://bugzilla.redhat.com/show_bug.cgi?id=455355
Ramsay, what version of glibc you have and in what distro? thanks
From: Christian Couder <hidden> Date: 2016-06-15 22:54:58
Hi,
On Mon, Oct 8, 2012 at 3:19 PM, Elia Pinto [off-list ref] wrote:
Ok. I have found. For me this is not a problem any more these days.
Was fixed in glibc 2.8.90-9 2008
* Wed Jul 16 2008 Jakub Jelinek [off-list ref] 2.8.90-9
- update from trunk
- fix unbuffered vfprintf if writing to the stream fails (#455360)
- remove useless "malloc: using debugging hooks" message (#455355)
- nscd fixes
(from glibc rpm changelog)
This is the bugzilla filled and closed
https://bugzilla.redhat.com/show_bug.cgi?id=455355
Ramsay, what version of glibc you have and in what distro? thanks
I have the same problem on a RHEL 5.3 (2.6.18-128.el5 #1 SMP Wed Dec
17 11:41:38 EST 2008 x86_64 x86_64 x86_64 GNU/Linux) with
glibc-2.5-34.
Best,
Christian.
From: Ramsay Jones <hidden> Date: 2016-06-15 22:54:59
Junio C Hamano wrote:
Ramsay Jones [off-list ref] writes:
quoted
The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
variable, either from the environment or command line of an
'make test' invocation. In order to allow the malloc checks to be
disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
to the environment using an export directive.
We would want to encourage people to test with cheap but effective
checks when available. I do not see "malloc: using debugging hooks"
message anywhere when I run tests, but if you do, I'd rather see us
check if we can tell glibc to stop doing so first without disabling
the whole test. Your patch feels like the first step to a slipperly
slope whose destination would make us say "we get too many messages
so let's do nothing in "make test" with this configuration." when
taken to the extreme, and obviously we would not want to go there
;-).
[sorry for the late reply, I've been away ...]
Yes, but ... I really don't see that this patch would encourage anyone
to skip the malloc checks, who wasn't going to anyway! I didn't notice
much of an increase in the running time of the tests, so that wouldn't
discourage me. This idiotic message spewage is a different issue.
(the complete loss of terminal scroll-back is particularly annoying)
I had intended to run the tests with malloc checks enabled before
submitting patches, testing -rc* builds etc., but have them disabled
for day-to-day programming.
Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK
to your environment before running "make test" suffice?
Yes, so I can simply disable the malloc checks in my ~/.bashrc file.
However, it would be disappointing to have my config tweeks in two
places ... :(
I guess I can live with it ...
ATB,
Ramsay Jones
From: Ramsay Jones <hidden> Date: 2016-06-15 22:54:59
Elia Pinto wrote:
2012/10/6 Junio C Hamano [off-list ref]:
quoted
Ramsay Jones [off-list ref] writes:
Elia, you brought the MALLOC_CHECK_ up. Did you hear about this
issue elsewhere before, and if you did, do you know how other
projects solves it?
Ok. I have found. For me this is not a problem any more these days.
Was fixed in glibc 2.8.90-9 2008
* Wed Jul 16 2008 Jakub Jelinek [off-list ref] 2.8.90-9
- update from trunk
- fix unbuffered vfprintf if writing to the stream fails (#455360)
- remove useless "malloc: using debugging hooks" message (#455355)
- nscd fixes
(from glibc rpm changelog)
This is the bugzilla filled and closed
https://bugzilla.redhat.com/show_bug.cgi?id=455355
Ramsay, what version of glibc you have and in what distro? thanks
The glibc version is 2.5, if I believe the changelog, along with:
ramsay$ ls -l /lib/libc.so.6
lrwxrwxrwx 1 root root 11 2007-06-24 19:44 /lib/libc.so.6 -> libc-2.5.so*
ramsay$
... but the header files tell a different story:
ramsay$ grep 'define __GLIBC_' /usr/include/features.h
#define __GLIBC__ 2
#define __GLIBC_MINOR__ 4
ramsay$
The distro is Ubuntu (but I can't remember which version; I would have
to re-boot to find out so ...).
HTH
ATB,
Ramsay Jones
Hemm, too old release distro , no ? 4-5 year ago. It is time to
upgrade to something more recent , 5.7 5.8 . Rhel5.3 is not a good
distro for a developer isn't it ?
2012/10/10, Ramsay Jones [off-list ref]:
Junio C Hamano wrote:
quoted
Ramsay Jones [off-list ref] writes:
quoted
The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
variable, either from the environment or command line of an
'make test' invocation. In order to allow the malloc checks to be
disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
to the environment using an export directive.
We would want to encourage people to test with cheap but effective
checks when available. I do not see "malloc: using debugging hooks"
message anywhere when I run tests, but if you do, I'd rather see us
check if we can tell glibc to stop doing so first without disabling
the whole test. Your patch feels like the first step to a slipperly
slope whose destination would make us say "we get too many messages
so let's do nothing in "make test" with this configuration." when
taken to the extreme, and obviously we would not want to go there
;-).
[sorry for the late reply, I've been away ...]
Yes, but ... I really don't see that this patch would encourage anyone
to skip the malloc checks, who wasn't going to anyway! I didn't notice
much of an increase in the running time of the tests, so that wouldn't
discourage me. This idiotic message spewage is a different issue.
(the complete loss of terminal scroll-back is particularly annoying)
I had intended to run the tests with malloc checks enabled before
submitting patches, testing -rc* builds etc., but have them disabled
for day-to-day programming.
quoted
Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK
to your environment before running "make test" suffice?
Yes, so I can simply disable the malloc checks in my ~/.bashrc file.
However, it would be disappointing to have my config tweeks in two
places ... :(
I guess I can live with it ...
ATB,
Ramsay Jones
No reboot. lsb-release -a from memory or something similar, always on travel...
Regards
2012/10/10, Elia Pinto [off-list ref]:
Hemm, too old release distro , no ? 4-5 year ago. It is time to
upgrade to something more recent , 5.7 5.8 . Rhel5.3 is not a good
distro for a developer isn't it ?
2012/10/10, Ramsay Jones [off-list ref]:
quoted
Junio C Hamano wrote:
quoted
Ramsay Jones [off-list ref] writes:
quoted
The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
variable, either from the environment or command line of an
'make test' invocation. In order to allow the malloc checks to be
disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
to the environment using an export directive.
We would want to encourage people to test with cheap but effective
checks when available. I do not see "malloc: using debugging hooks"
message anywhere when I run tests, but if you do, I'd rather see us
check if we can tell glibc to stop doing so first without disabling
the whole test. Your patch feels like the first step to a slipperly
slope whose destination would make us say "we get too many messages
so let's do nothing in "make test" with this configuration." when
taken to the extreme, and obviously we would not want to go there
;-).
[sorry for the late reply, I've been away ...]
Yes, but ... I really don't see that this patch would encourage anyone
to skip the malloc checks, who wasn't going to anyway! I didn't notice
much of an increase in the running time of the tests, so that wouldn't
discourage me. This idiotic message spewage is a different issue.
(the complete loss of terminal scroll-back is particularly annoying)
I had intended to run the tests with malloc checks enabled before
submitting patches, testing -rc* builds etc., but have them disabled
for day-to-day programming.
quoted
Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK
to your environment before running "make test" suffice?
Yes, so I can simply disable the malloc checks in my ~/.bashrc file.
However, it would be disappointing to have my config tweeks in two
places ... :(
I guess I can live with it ...
ATB,
Ramsay Jones