SZEDER Gábor [off-list ref] writes:
On Wed, Sep 26, 2012 at 05:57:00PM -0400, Jeff King wrote:
quoted
+ COMPREPLY[$i]="${COMPREPLY[$i]}$stripped"
This reminded me to a mini-series collecting dust in my git repo,
which converts a few similar var=$var$something constructs to use the
+= append operator instead.
Is the benefit of rewriting it to var+=$something large enough to
worry about the below?
Now, Bash supports this += append operator since v3.1
(bash-3.1-alpha1, to be exact), which is around since July 2005, if I
can trust the mtime at ftp://ftp.cwru.edu/pub/bash/. MSysgit ships
v3.1 so it already supports this, too. So, what is the oldest Bash
version we care about for completion?
On Thu, Sep 27, 2012 at 03:31:10PM -0700, Junio C Hamano wrote:
SZEDER Gábor [off-list ref] writes:
quoted
On Wed, Sep 26, 2012 at 05:57:00PM -0400, Jeff King wrote:
quoted
+ COMPREPLY[$i]="${COMPREPLY[$i]}$stripped"
This reminded me to a mini-series collecting dust in my git repo,
which converts a few similar var=$var$something constructs to use the
+= append operator instead.
Is the benefit of rewriting it to var+=$something large enough to
worry about the below?
That way we can get rid of a subshell in __gitcomp(), which means one
less fork() during every command or option completion for Windows
folks. We can also get rid of two subshells during loading the
completion script.
And I would spare myself from a couple of merge conflicts, too ;)
quoted
Now, Bash supports this += append operator since v3.1
(bash-3.1-alpha1, to be exact), which is around since July 2005, if I
can trust the mtime at ftp://ftp.cwru.edu/pub/bash/. MSysgit ships
v3.1 so it already supports this, too. So, what is the oldest Bash
version we care about for completion?