Re: [PATCH v4] Teach rm to remove submodules unless they contain a git directory

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v4] Teach rm to remove submodules unless they contain a git directory

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:52

Jens Lehmann [off-list ref] writes:
Changes since v3:
- Added get_ours_cache_pos() helper to only check stage 2 of a conflict
- Added tests for modified submodules in the conflict case
Thanks.
+			/*
+			 * Skip unmerged entries except for populated submodules
+			 * that could loose history when removed.
+			 */
s/loose/lose/, I think.

Re: [PATCH v4] Teach rm to remove submodules unless they contain a git directory

From: Jens Lehmann <hidden>
Date: 2016-06-15 22:54:54

Am 27.09.2012 18:53, schrieb Junio C Hamano:
Jens Lehmann [off-list ref] writes:
quoted
+			/*
+			 * Skip unmerged entries except for populated submodules
+			 * that could loose history when removed.
+			 */
s/loose/lose/, I think.
Thanks for squashing that one in!

I also used "loose" in the commit message where "lose" would have been
correct. I can resend a new version correcting both if you want.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help