Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

From: Andreas Schwab <hidden>
Date: 2016-06-15 22:54:50

Jeff King [off-list ref] writes:
A bigger question is: why are you setting SHELL=zsh in the first place?
SHELL is set to the login shell by default.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

From: Jeff King <hidden>
Date: 2016-06-15 22:54:50

On Fri, Sep 21, 2012 at 11:08:34PM +0200, Andreas Schwab wrote:
Jeff King [off-list ref] writes:
quoted
A bigger question is: why are you setting SHELL=zsh in the first place?
SHELL is set to the login shell by default.
Yeah, sorry, I was thinking this was coming from our $SHELL_PATH
Makefile variable, and that he was setting that. The real solution is to
properly use $SHELL_PATH instead of $SHELL.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help