Re: [PATCHv4] clone --single: limit the fetch refspec to fetched branch

Nguyen Thai Ngoc Duy [off-list ref] writes:

--mirror --single-branch combination does not look right. The "heads/"
part is missing..

What does it supposed to do in the first place?  "mirror" is
primarily about grabbing everything without leaving stuff out, and
"single" is about grabbing only one thing without other stuff.  It
smells like a nonsense case we didn't even bother to catch and
diagnose as an error to me.

Besides, mirror implies bare, so we would expect to see

    refs/heads/$single:refs/heads/$single

and that matches what the "single" gives us without "mirror", no?

How about explicitly forbidding that combination, or ignoring mirror
when single is given?

On Tue, Sep 18, 2012 at 3:08 AM, Junio C Hamano [off-list ref] wrote:

Nguyen Thai Ngoc Duy [off-list ref] writes:

quoted

--mirror --single-branch combination does not look right. The "heads/"
part is missing..

What does it supposed to do in the first place?  "mirror" is
primarily about grabbing everything without leaving stuff out, and
"single" is about grabbing only one thing without other stuff.  It
smells like a nonsense case we didn't even bother to catch and
diagnose as an error to me.

Besides, mirror implies bare, so we would expect to see

    refs/heads/$single:refs/heads/$single

and that matches what the "single" gives us without "mirror", no?

Yes that's what I think it should do too.

How about explicitly forbidding that combination, or ignoring mirror
when single is given?

I see nothing wrong with mirroring just one branch. But if handling it
is too complex than forbidding it is fine.
-- 
Duy