Re: [PATCHv2 01/12] git p4 test: remove bash-ism of combined export/assignment

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCHv2 01/12] git p4 test: remove bash-ism of combined export/assignment

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:46

Luke Diamand [off-list ref] writes:
On 16/09/12 07:05, Junio C Hamano wrote:
quoted
Luke Diamand[off-list ref]  writes:
quoted
Looks good to me, ack.
Thanks; is this an ack for the entire series, or are you expecting
further back-and-forth with Pete before the whole thing is ready?
An ack for the whole series. I'm just going through the rest of the
patches now but I don't expect to find any issues.
As long as the parties involved in the part of the system can agree
that "this series is basically sound", I'd be happy to merge it
down. Minor issues can be fixed up as follow-up patches.

Thanks.  Will merge it to 'next'.

Re: [PATCHv2 01/12] git p4 test: remove bash-ism of combined export/assignment

From: Luke Diamand <hidden>
Date: 2016-06-15 22:54:46

On 17/09/12 05:50, Junio C Hamano wrote:
Luke Diamand[off-list ref]  writes:
quoted
On 16/09/12 07:05, Junio C Hamano wrote:
quoted
Luke Diamand[off-list ref]   writes:
quoted
Looks good to me, ack.
Thanks; is this an ack for the entire series, or are you expecting
further back-and-forth with Pete before the whole thing is ready?
An ack for the whole series. I'm just going through the rest of the
patches now but I don't expect to find any issues.
As long as the parties involved in the part of the system can agree
that "this series is basically sound", I'd be happy to merge it
down. Minor issues can be fixed up as follow-up patches.
Basically sound as far as I'm concerned.
Thanks.  Will merge it to 'next'.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help