Re: [PATCH] Revert diffstat back to English

Junio C Hamano [off-list ref] writes:

Nguyễn Thái Ngọc Duy [off-list ref] writes:

quoted

 Git is still partly i18n-ized, turning a few strings back does not
 seem a big regression.

More than one people explicitly said that they do not want to see
this in Klingon.  Even if the system is fully internationalized,
these "... (+), ... (-)" should never be localized, just like we
will never localize "diff --git", "index f00f..abcd", etc.

Nah, I was being silly.  People complaining on Klingon on _this_
list does not argue for this to be in "C"; it just means the
i18n.projectlang for this project is "C".

How about _not_ reverting it and doing something like this instead?
I suspect that we may need to delay the call to git_setup_gettext()
in a similar way that we delay the call to commit_pager_choice(),
but that is a minor detail people smarter than I can surely figure
out ;-)

 git.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git i/git.c w/git.c
index 8788b32..a2cb9c8 100644
--- i/git.c
+++ w/git.c

@@ -51,6 +51,15 @@ int check_pager_config(const char *cmd)
 	return c.want;
 }
 
+static int project_lang_config(const char *var, const char *value, void *cb_data)
+{
+	if (!strcmp(var, "i18n.projectlang")) {
+		setenv("LANG", val, 1);
+		setenv("LC_ALL", val, 1);
+	}
+	return 0;
+}
+
 static void commit_pager_choice(void) {
 	switch (use_pager) {
 	case 0:

@@ -538,6 +547,7 @@ int main(int argc, const char **argv)
 	if (!cmd)
 		cmd = "git-help";
 
+	git_config(project_lang_config, NULL);
 	git_setup_gettext();
 
 	/*

On Thu, Sep 13, 2012 at 11:40:12AM -0700, Junio C Hamano wrote:

quoted

More than one people explicitly said that they do not want to see
this in Klingon.  Even if the system is fully internationalized,
these "... (+), ... (-)" should never be localized, just like we
will never localize "diff --git", "index f00f..abcd", etc.

Nah, I was being silly.  People complaining on Klingon on _this_
list does not argue for this to be in "C"; it just means the
i18n.projectlang for this project is "C".

Right, I think that is the case.

How about _not_ reverting it and doing something like this instead?
[...]
+static int project_lang_config(const char *var, const char *value, void *cb_data)
+{
+	if (!strcmp(var, "i18n.projectlang")) {
+		setenv("LANG", val, 1);
+		setenv("LC_ALL", val, 1);
+	}
+	return 0;
+}

Doesn't that mean that anyone working on git.git will never get to see
their localized language, even when it is not likely to be communicated
to the rest of the project? I am OK with that as a native speaker, but I
wonder what others would have to say.

I suspect we will end up with people not setting i18n.projectlang, and
getting Klingon diffstats on the list.

-Peff