Re: Restore hostname logging in inetd mode

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: Restore hostname logging in inetd mode

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:42

Please don't throw a pull request for a patch whose worth hasn't
been justified in a discussion on the list.  Thanks.

Re: Restore hostname logging in inetd mode

From: Jan Engelhardt <hidden>
Date: 2016-06-15 22:54:42

On Saturday 2012-09-08 20:57, Junio C Hamano wrote:
Please don't throw a pull request for a patch whose worth hasn't
been justified in a discussion on the list.  Thanks.
Let me postulate that people like to get cover letters with the
git:// URL so they can fetch+look at it, a diffstat and shortlog.

And 'lo, that is exactly what git-request-pull thankfully generates.

In my defense: Just because the command is called "request-pull",
does not mean you absolutely have to merge/pull it. In fact, it does
not even mention merge/pull at all.

"
The following changes since commit [SHA]:
  [Commit Message]
are available in the git repository at:
  git://[...]
for you to fetch changes up to [SHA]:
  [Commit Message]
[diffstat,shortlog]
"

In contrast to many a LKML postings which explicitly state the pull
intent:

"
Hi [Maintainer],

Please pull from the git repository at
  [URL]
to receive [...]
  [SHA]
  [Commit Message]
on top of commit [SHA]
  [Commit Message]
[diffstat,shortlog]
"
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help