DORMANTno replies

[PATCH] cvsimport: strip question marks from tags

From: Ken Dreyer <hidden>
Date: 2016-06-15 22:54:38
Subsystem: the rest · Maintainer: Linus Torvalds

The "?" character can be present in a CVS tag name, but git's
bad_ref_char does not allow question marks in git tags. If
git-cvsimport encounters a CVS tag with a question mark, it will error
and refuse to continue the import beyond that point.

When importing CVS tags, strip "?" characters from the tag names as we
translate them to git tag names.

Signed-off-by: Ken Dreyer <redacted>
---
 git-cvsimport.perl | 1 +
 1 file changed, 1 insertion(+)
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index 8d41610..36f59fe 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -890,6 +890,7 @@ sub commit {
 		$xtag =~ tr/_/\./ if ( $opt_u );
 		$xtag =~ s/[\/]/$opt_s/g;
 		$xtag =~ s/\[//g;
+		$xtag =~ s/\?//g;
 
 		system('git' , 'tag', '-f', $xtag, $cid) == 0
 			or die "Cannot create tag $xtag: $!\n";
-- 
1.7.11.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help