Bug: Recursive submodules fail when the repo path contains spaces

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

Bug: Recursive submodules fail when the repo path contains spaces

From: Justin Spahr-Summers <hidden>
Date: 2016-06-15 22:54:19

This occurs on Mac OS X 10.7.4, on git versions 1.7.10.2 (Apple Git-33) and 1.7.11.3.

Steps:
 1. Create or clone a repository to an absolute path that contains spaces.
 2. Add a submodule to the repository, if it does not already have one.
 3. Within that submodule, attempt to add another submodule.

The result is an error "fatal: Not a git repository", followed by the relative path to the submodule directory within .git/modules of the top-level repository.

Similarly, using "git submodule update --init --recursive" in a freshly-cloned repository that matches the above configuration will fail with the same error. "git clone --recursive" does not seem to suffer from the same problem at clone time, but will still fail to add recursive submodules.

-- 
Justin Spahr-Summers

Re: Bug: Recursive submodules fail when the repo path contains spaces

From: Jens Lehmann <hidden>
Date: 2016-06-15 22:54:19

Am 24.07.2012 21:01, schrieb Justin Spahr-Summers:
This occurs on Mac OS X 10.7.4, on git versions 1.7.10.2 (Apple Git-33) and 1.7.11.3.

Steps:
 1. Create or clone a repository to an absolute path that contains spaces.
 2. Add a submodule to the repository, if it does not already have one.
 3. Within that submodule, attempt to add another submodule.

The result is an error "fatal: Not a git repository", followed by the relative path to the submodule directory within .git/modules of the top-level repository.

Similarly, using "git submodule update --init --recursive" in a freshly-cloned repository that matches the above configuration will fail with the same error. "git clone --recursive" does not seem to suffer from the same problem at clone time, but will still fail to add recursive submodules.
Hmm, I don't understand how that is different from what t7407 does, it uses
"git submodule update --init --recursive" in to populate recursive submodules
in a freshly cloned repository whose path contains a space (in the trash
directory name) in test number 8.

Does the git test suite succeed for you?

Re: Bug: Recursive submodules fail when the repo path contains spaces

From: Justin Spahr-Summers <hidden>
Date: 2016-06-15 22:54:19

On Tuesday, 24. July 2012 at 13:08, Jens Lehmann wrote:
Am 24.07.2012 21:01, schrieb Justin Spahr-Summers:
quoted
This occurs on Mac OS X 10.7.4, on git versions 1.7.10.2 (Apple Git-33) and 1.7.11.3.
 
Steps:
1. Create or clone a repository to an absolute path that contains spaces.
2. Add a submodule to the repository, if it does not already have one.
3. Within that submodule, attempt to add another submodule.
 
The result is an error "fatal: Not a git repository", followed by the relative path to the submodule directory within .git/modules of the top-level repository.
 
Similarly, using "git submodule update --init --recursive" in a freshly-cloned repository that matches the above configuration will fail with the same error. "git clone --recursive" does not seem to suffer from the same problem at clone time, but will still fail to add recursive submodules.
 
Hmm, I don't understand how that is different from what t7407 does, it uses
"git submodule update --init --recursive" in to populate recursive submodules
in a freshly cloned repository whose path contains a space (in the trash
directory name) in test number 8.
 
Does the git test suite succeed for you?  
The only test that fails is:  

*** t7501-commit.sh ***
*** t7502-commit.sh ***
…
not ok - 13 commit message from template with whitespace issue



(which I assume is unrelated)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help