Re: [PATCH 3/7] autoconf: remove some redundant shell indirections

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 3/7] autoconf: remove some redundant shell indirections

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:54:17 

Stefano Lattarini [off-list ref] writes:
quoted hunk
diff --git a/configure.ac b/configure.ac
index 789926f..9472f6b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -29,13 +29,12 @@ AC_DEFUN([GIT_ARG_SET_PATH],
 # --without-PROGRAM is used.
 AC_DEFUN([GIT_CONF_APPEND_PATH],
     [m4_pushdef([GIT_UC_PROGRAM], m4_toupper([$1]))dnl
     if test "$withval" = "no"; then
 	if test -n "$2"; then
 		GIT_UC_PROGRAM[]_PATH=$withval
+		AC_MSG_NOTICE([Disabling use of GIT_UC_PROGRAM])
+		GIT_CONF_SUBST([NO_]GIT_UC_PROGRAM, [YesPlease])
+		GIT_CONF_SUBST(GIT_UC_PROGRAM[_PATH], [])
Nice.

The inconsistency between the existing one that does not quote the
string that is not substituted, i.e.

	GIT_UC_PROGRAM[]_PATH=$withval

and the new one that quotes _PATH, i.e.

	GIT_CONF_SUBST(GIT_UC_PROGRAM[_PATH], [])

looks somewhat strange, though.

Re: [PATCH 3/7] autoconf: remove some redundant shell indirections

From: Stefano Lattarini <hidden>
Date: 2016-06-15 22:54:17 

On 07/19/2012 02:29 AM, Junio C Hamano wrote:
The inconsistency between the existing one that does not quote the
string that is not substituted, i.e.

	GIT_UC_PROGRAM[]_PATH=$withval

and the new one that quotes _PATH, i.e.

	GIT_CONF_SUBST(GIT_UC_PROGRAM[_PATH], [])

looks somewhat strange, though.
Will fix that in the re-roll.

Thanks,
  Stefano
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help