Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

Zbigniew Jędrzejewski-Szmek [off-list ref] writes:

On 06/08/2012 04:32 AM, Martin Langhoff wrote:

quoted

git log -G'regex' is a very usable alternative to the classic
pickaxe. Minimal patch to make it usable from gitk.

quoted

     set gm [makedroplist .tf.lbar.gdttype gdttype \
 		[mc "containing:"] \
 		[mc "touching paths:"] \
-		[mc "adding/removing string:"]]
+		[mc "adding/removing string:"] \
+		[mc "changes match regex:"]]

Hi,

this feature is definitely useful. One nitpick: the string that you add
becomes part of a sentence in the GUI: "prev/next commit changes match
regex", which is in different grammatical form then the existing
snippets. Should be something with '-ing'.

"prev/next commit with changes matching regex" perhaps?

In any case, Paul needs to be in the loop when we discuss gitk
changes.

On Sat, Jun 09, 2012 at 11:37:58PM -0700, Junio C Hamano wrote:

Zbigniew Jędrzejewski-Szmek [off-list ref] writes:

quoted

On 06/08/2012 04:32 AM, Martin Langhoff wrote:

quoted

git log -G'regex' is a very usable alternative to the classic
pickaxe. Minimal patch to make it usable from gitk.

quoted

     set gm [makedroplist .tf.lbar.gdttype gdttype \
 		[mc "containing:"] \
 		[mc "touching paths:"] \
-		[mc "adding/removing string:"]]
+		[mc "adding/removing string:"] \
+		[mc "changes match regex:"]]

Hi,

this feature is definitely useful. One nitpick: the string that you add
becomes part of a sentence in the GUI: "prev/next commit changes match
regex", which is in different grammatical form then the existing
snippets. Should be something with '-ing'.

"prev/next commit with changes matching regex" perhaps?

There is already the drop-down list to select exact, case-ignoring or
regexp matching.  I would think that "adding/removing string" combined
with "Regexp" matching should select this.

What exactly does git log -G do?

Paul.