Re: Bug: rebase when an author uses accents in name on MacOSx

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: Bug: rebase when an author uses accents in name on MacOSx

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:57

Jeff King [off-list ref] writes:
On Wed, May 30, 2012 at 04:45:33PM -0700, Junio C Hamano wrote:
...
quoted
So in C locale where each byte is supposed to be a single character,
that implementation of "sed" refuses to match a byte with high-bit
set when given a pattern '.'?

That is a surprising breakage, I would have to say.
It should not be too surprising, since we discussed it a few months ago:

  http://thread.gmane.org/gmane.comp.version-control.git/192218
Heh, no wonder I do not recall that one, as everything happened and
conclusions reached while I was sleeping ;-)

If it is not a bug in platform-sanctioned sed, but a buggy
third-party build, then I wouldn't worry about it for this cycle,
but pre-release freeze might be a good time to start sketching
Thomas's --format="%'%an <%ae>%'" approach, perhaps?

Re: Bug: rebase when an author uses accents in name on MacOSx

From: Lanny Ripple <hidden>
Date: 2016-06-15 22:53:57

Bingo.

  lanny;~> echo "Rémi Leblond" | LANG=C LC_ALL=C /usr/bin/sed -ne 's/.*/GIT_AUTHOR_NAME='\''&'\''/p'
  GIT_AUTHOR_NAME='Rémi Leblond'

Just occurred to me that I'm using fink and that git-am doesn't use /usr/bin/sed but just sed.  My suggestion is to be explicit on the path in git-am.

So it now stands at two bug-reports and one pebkac.

  Thanks!,
  -ljr
---
Lanny Ripple
lanny@spotinfluence.com


On May 31, 2012, at 1:33 AM, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
On Wed, May 30, 2012 at 04:45:33PM -0700, Junio C Hamano wrote:
...
quoted
So in C locale where each byte is supposed to be a single character,
that implementation of "sed" refuses to match a byte with high-bit
set when given a pattern '.'?

That is a surprising breakage, I would have to say.
It should not be too surprising, since we discussed it a few months ago:

 http://thread.gmane.org/gmane.comp.version-control.git/192218
Heh, no wonder I do not recall that one, as everything happened and
conclusions reached while I was sleeping ;-)

If it is not a bug in platform-sanctioned sed, but a buggy
third-party build, then I wouldn't worry about it for this cycle,
but pre-release freeze might be a good time to start sketching
Thomas's --format="%'%an <%ae>%'" approach, perhaps?

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help