Vietnamese l10n pull request problems

Hi, all

Vnwildman, the new git l10n team leader for Vietnamese send me a huge
pull request, it has some problems I think other l10n teams should care about.

The URL for the pull request is https://github.com/git-l10n/git-po/pull/22 .

1. Commit log should has a signed-off-by line, no dought

2. Trival commits (from the same contributor, with not description in
    commit log) should be squashed or not, I am not sure.

    The comment is at:
https://github.com/git-l10n/git-po/pull/22#issuecomment-5954319

quoted

From Trần Ngọc Quân <vnwildman AT gmail.com>：

quoted

squash

It isn't necessary. When you pull from my repository, it will merger automatically.

If the six commits are from different people, or each commit is atomic and is
necessary for other contributors to review it, or every commit has a well written
commit log (with not only single subject line, Signed-off-by line, but also with
detail description for the commit), you won't squash them.

3. l10n team leaders should not merge git upstream directly.

quoted

Oh dear!I hate to change history!

You must clean your history for two reasons:

1. One pull request to upstream git.git was rejected by Junio, for
    one commit from the German team hacked files outside po/
    directory. So I changed the history of git-l10n/git-po. I am sorry
    you are victim for this.

2. You pull from git.git, such as commit 95a3338c8dc,
    25d0a1d66462, 0851be, ad32d7f.
    which are not suitable for l10n team leaders.
    Don't do that, I can not review these merge commits.

4. Fuzzy tranlations must be fixed before pull request can be accepted
    and closed.

    Comment URL: https://github.com/git-l10n/git-po/pull/22#issuecomment-5954625

quoted

quoted

I also found that there were 28 fuzzy translations in your vi.po.
You must fix them before I can close this pull request.

fuzzy translations, Why it is the problem?

Fuzzy means wrong, outofdate translation, I will make Vietnamese
people puzzled. For example, orignal message is
"Delete file, yes or NO? (default no)", but the fuzzy translation is
"Delete file, YES or no? (default yes)". You translation will hurt others.

But you can leave them untranslated. Untranslated l10n message is OK.

quoted

The last question:
So, I have to change my history, don't I?

You have to make your history more clear, for the two reasons I just talked above.
But for fuzzy translations, you can just make another commit and fix them.

--
Jiang Xin