Re: [PATCH 1/2] git-p4: Test changelists touching two branches

Vitor Antunes [off-list ref] writes:

What about the parentheses in the next line, is it necessary? Or can I
simply remove that pair of parentheses and unindent the code in
between?

quoted

...

quoted

+     (
+             cd "$cli" &&
+             p4 integrate //depot/branch3/file3 //depot/branch4/file3 &&
+             p4 delete //depot/branch3/file3 &&
+             p4 submit -d "Move branch3/file3 to branch4/file3"
+     )
+'

If you mean this part, the parentheses to throw you into a subprocess are
required.  Otherwise, a failure in any of these three p4 commands will
leave you in $cli directory, causing the next test to start in a directory
that it does not expect.

On Fri, May 25, 2012 at 1:02 AM, Junio C Hamano [off-list ref] wrote:

Vitor Antunes [off-list ref] writes:

quoted

What about the parentheses in the next line, is it necessary? Or can I
simply remove that pair of parentheses and unindent the code in
between?

quoted

...

quoted

+     (
+             cd "$cli" &&
+             p4 integrate //depot/branch3/file3 //depot/branch4/file3 &&
+             p4 delete //depot/branch3/file3 &&
+             p4 submit -d "Move branch3/file3 to branch4/file3"
+     )
+'

If you mean this part, the parentheses to throw you into a subprocess are
required.  Otherwise, a failure in any of these three p4 commands will
leave you in $cli directory, causing the next test to start in a directory
that it does not expect.

That makes sense and is quite obvious now that I _see_ it.

Thanks for your help Junio.

Vitor