Re: [PATCH 1/2] completion: rename _git and _gitk

SZEDER Gábor [off-list ref] writes:

quoted

-_git ()
+_main_git ()

quoted

-_gitk ()
+_main_gitk ()

After all those namespace discussions the names of these functions
should start with _git or __git.

As these are pure implementation internal details that are called from
very limited places, I do not think Felipe minds a patch to update them.

Personally I would find _git_git or __git_git even more mysterious and
begs one-liner comments above their definition, though.

Thanks.

On Tue, May 22, 2012 at 8:00 PM, Junio C Hamano [off-list ref] wrote:

SZEDER Gábor [off-list ref] writes:

quoted

quoted

-_git ()
+_main_git ()

quoted

-_gitk ()
+_main_gitk ()

After all those namespace discussions the names of these functions
should start with _git or __git.

As these are pure implementation internal details that are called from
very limited places, I do not think Felipe minds a patch to update them.

I don't mind updating these to whatever you decide is the namespace
for internal functions, just avoid _git ().

Cheers.

-- 
Felipe Contreras