2 messages, 2 authors, 2016-06-15 · open the first message on its own page
From: Felipe Contreras <hidden>
Date: 2016-06-15 22:53:50
Hi,
It looks like authors ending with a dot ('Foo Jr. [off-list ref]') are
converted without a dot ('Foo Jr [off-list ref]') is that intentional?
Cheers.
--
Felipe Contreras
From: Jeff King <hidden>
Date: 2016-06-15 22:53:51
On Fri, May 18, 2012 at 02:14:57AM +0200, Felipe Contreras wrote:
It looks like authors ending with a dot ('Foo Jr. [off-list ref]') are
converted without a dot ('Foo Jr [off-list ref]') is that intentional?
I was just digging in this code today, and I noticed the same thing. The
culprit is ident.c:copy, which strips magic characters from the
beginning, end, and middle. Except that the set of magic characters is
different at the edges (see ident.c:crud), and in the middle ("<", ">",
"\n").
This dates all the way back to 6aa33f4 (Abstract out the "name <email>
date" handling of commit-tree.c, 2005-07-12), which in turn was adapting
code from earlier (though it also has the issue).
So I think it's intentional, but I also think it's wrong, and it's
simply that nobody has complained about it, because it's not that
common.
-Peff