Re: [PATCH v2] git-svn: clarify the referent of dcommit's optional argument

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v2] git-svn: clarify the referent of dcommit's optional argument

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:50

Jon Seymour [off-list ref] writes:
On Tue, May 15, 2012 at 2:16 AM, Junio C Hamano [off-list ref] wrote:
quoted
The only reason why the original is not ordered that way, as far as I can
tell, is because "It is recommended that" was part of an existing paragraph
when dd31da2 (git-svn: allow dcommit to take an alternate head, 2006-12-12)
added "An optional ...", so it was tucked after existing paragraph without
reading the resulting whole to see if "at the very end" was the best place.
Re-reading this, I don't think the advice:

    "It is recommended that you run 'git svn' fetch and rebase (not
    pull or merge) your commits against the latest changes in the =C2=A0SVN
    repository."

really belongs in the description of dcommit at all.
I tend to agree.  Opinions from git-svn experts?

Re: [PATCH v2] git-svn: clarify the referent of dcommit's optional argument

From: Eric Wong <hidden>
Date: 2016-06-15 22:53:50

Junio C Hamano [off-list ref] wrote:
Jon Seymour [off-list ref] writes:
quoted
Re-reading this, I don't think the advice:

    "It is recommended that you run 'git svn' fetch and rebase (not
    pull or merge) your commits against the latest changes in the =C2=A0SVN
    repository."

really belongs in the description of dcommit at all.
I tend to agree.  Opinions from git-svn experts?
I agree, too.   It should be moved to/reworded for the
"REBASE VS. PULL/MERGE" section instead.

Re: [PATCH v2] git-svn: clarify the referent of dcommit's optional argument

From: Thomas Rast <hidden>
Date: 2016-06-15 22:53:50

Junio C Hamano [off-list ref] writes:
Jon Seymour [off-list ref] writes:
quoted
On Tue, May 15, 2012 at 2:16 AM, Junio C Hamano [off-list ref] wrote:
quoted
The only reason why the original is not ordered that way, as far as I can
tell, is because "It is recommended that" was part of an existing paragraph
when dd31da2 (git-svn: allow dcommit to take an alternate head, 2006-12-12)
added "An optional ...", so it was tucked after existing paragraph without
reading the resulting whole to see if "at the very end" was the best place.
Re-reading this, I don't think the advice:

    "It is recommended that you run 'git svn' fetch and rebase (not
    pull or merge) your commits against the latest changes in the =C2=A0SVN
    repository."

really belongs in the description of dcommit at all.
I tend to agree.  Opinions from git-svn experts?
I agree that this is not dcommit-specific advice.  Perhaps there should
be a longer section that explains in detail what is rebased how and thus
what the limitations of dcommit are.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help