Re: [PATCH v5] completion: add new __git_complete helper

Felipe Contreras [off-list ref] writes:

quoted

Here is my attempt to explain why none of them needs to be quoted:
...

I don't understand that.

That was my attempt to give the readers some context to understand what
comes after that.  If the original patch author does not understand it,
perhaps it is an indication that the function is somewhat underdocumented.

quoted

 # wrapper: the name of an internal shell function that wraps the

...
So in short; because the variables are used as function/command names.

Yes, and the fact that this is internal and we won't listen to clueless
people who attempt "__git_complete 'foo bar' 'bar boz'" and complain are
what make all of them safe to be used without any quotes around it.

On Mon, May 14, 2012 at 9:09 PM, Junio C Hamano [off-list ref] wrote:

Felipe Contreras [off-list ref] writes:

quoted

quoted

Here is my attempt to explain why none of them needs to be quoted:
...

I don't understand that.

That was my attempt to give the readers some context to understand what
comes after that.  If the original patch author does not understand it,
perhaps it is an indication that the function is somewhat underdocumented.

I mean I don't understand this "Note that none of the variable
reference in the implementation of this function needs dq around it."
I suppose you meant 'references' (as that would make it grammatically
correct AFAICS), but I still don't understand what you are trying so
say. That the way the arguments are used in the __git_complete
function makes it so double quotes are irrelevant?

If so, then yeah, I agree.

Is there something actionable?

-- 
Felipe Contreras