Re: [PATCH 2/2] gitweb: Option to not display information about owner

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 2/2] gitweb: Option to not display information about owner

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:40

Kacper Kornet [off-list ref] writes:
In some setups the repository owner is not a well defined concept
and administrator can prefer it to be not shown. This commit add
and an option that enable to reach this effect.

Signed-off-by: Kacper Kornet <redacted>
Among your recent three patches, this one seems to break t9500; has it
been tested?

[Thu Apr 26 04:32:36 2012] gitweb.perl: Use of uninitialized value in string comparison (cmp) at /srv/git/t/../gitweb/gitweb.perl line 5551.
[Thu Apr 26 04:32:36 2012] gitweb.perl: Use of uninitialized value in string comparison (cmp) at /srv/git/t/../gitweb/gitweb.perl line 5551.
[Thu Apr 26 04:32:36 2012] gitweb.perl: Use of uninitialized value in hash element at /srv/git/t/../gitweb/gitweb.perl line 5401.
[Thu Apr 26 04:32:36 2012] gitweb.perl: Use of uninitialized value in hash element at /srv/git/t/../gitweb/gitweb.perl line 5401.

I am guessing both #5401 and #5551 are $it->{'category'} of @projects[]
elements.

Re: [PATCH 2/2] gitweb: Option to not display information about owner

From: Kacper Kornet <hidden>
Date: 2016-06-15 22:53:40

On Wed, Apr 25, 2012 at 09:39:03PM -0700, Junio C Hamano wrote:
Kacper Kornet [off-list ref] writes:
quoted
In some setups the repository owner is not a well defined concept
and administrator can prefer it to be not shown. This commit add
and an option that enable to reach this effect.
quoted
Signed-off-by: Kacper Kornet <redacted>
Among your recent three patches, this one seems to break t9500; has it
been tested?
[Thu Apr 26 04:32:36 2012] gitweb.perl: Use of uninitialized value in string comparison (cmp) at /srv/git/t/../gitweb/gitweb.perl line 5551.
[Thu Apr 26 04:32:36 2012] gitweb.perl: Use of uninitialized value in string comparison (cmp) at /srv/git/t/../gitweb/gitweb.perl line 5551.
[Thu Apr 26 04:32:36 2012] gitweb.perl: Use of uninitialized value in hash element at /srv/git/t/../gitweb/gitweb.perl line 5401.
[Thu Apr 26 04:32:36 2012] gitweb.perl: Use of uninitialized value in hash element at /srv/git/t/../gitweb/gitweb.perl line 5401.
I am guessing both #5401 and #5551 are $it->{'category'} of @projects[]
elements.
Yes, I have tested the tree with:

gitweb: Improve repository verification
gitweb: Option to omit column with time of the last change
gitweb: Option to not display information about owner

applied on top of v1.7.10. And all tests except 't91??' are passed.
Could you write on top of which revision have you applied these three
patches?

-- 
  Kacper Kornet
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help