[PATCHv1] git p4: fix for submit/edit unit test

2 messages, 1 author, 2016-06-15 · open the first message on its own page

[PATCHv1] git p4: fix for submit/edit unit test

From: Luke Diamand <hidden>
Date: 2016-06-15 22:53:40

My P4EDITOR changes broke the submit/edit "git p4" unit test.
This fixes it.

Junio - would you prefer me to resubmit the entire series?

Thanks
Luke


Luke Diamand (1):
  git p4: fix unit tests

 t/t9805-git-p4-skip-submit-edit.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.10.473.g0796

[PATCH] git p4: fix unit tests

From: Luke Diamand <hidden>
Date: 2016-06-15 22:53:40

The submit-edit tests relied on P4EDITOR being unset. Set it
explicitly to an empty string.

Signed-off-by: Luke Diamand <redacted>
---
 t/t9805-git-p4-skip-submit-edit.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t9805-git-p4-skip-submit-edit.sh b/t/t9805-git-p4-skip-submit-edit.sh
index 4a72f79..353dcfb 100755
--- a/t/t9805-git-p4-skip-submit-edit.sh
+++ b/t/t9805-git-p4-skip-submit-edit.sh
@@ -91,7 +91,7 @@ test_expect_success 'no config, edited' '
 		cd "$git" &&
 		echo line >>file1 &&
 		git commit -a -m "change 5" &&
-		EDITOR="\"$ed\"" git p4 submit &&
+		P4EDITOR="" EDITOR="\"$ed\"" git p4 submit &&
 		p4 changes //depot/... >wc &&
 		test_line_count = 5 wc
 	)
-- 
1.7.10.473.g0796
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help