Re: gitk: Failure of new tabbed preferences dialog

Pat Thoyts [off-list ref] writes:

quoted

I just tried the new gitk (master @fae9d76) and, since I don't have
themed widgets, the preferences menu item uses the emulated tabbed
dialog code, which fails like so:

    can't read "col": no such variable

The issue here is that the incr command has changed between tcl 8.4
and 8.5 and in more recent versions automatically creates the named
variable if it did not exist. The fix you suggest is correct. I've
also included another that I realised had been applied to msysGit and
was not posted upstream.

This seems severe enough that we should put it in the coming release.
I can queue them directory to gitk tree (and later ask Paul to pull it
from me), and merge the result to expedite the roundtrip.

On Mon, Apr 02, 2012 at 09:19:00AM -0700, Junio C Hamano wrote:

Pat Thoyts [off-list ref] writes:

quoted

quoted

I just tried the new gitk (master @fae9d76) and, since I don't have
themed widgets, the preferences menu item uses the emulated tabbed
dialog code, which fails like so:

    can't read "col": no such variable

The issue here is that the incr command has changed between tcl 8.4
and 8.5 and in more recent versions automatically creates the named
variable if it did not exist. The fix you suggest is correct. I've
also included another that I realised had been applied to msysGit and
was not posted upstream.

This seems severe enough that we should put it in the coming release.
I can queue them directory to gitk tree (and later ask Paul to pull it
from me), and merge the result to expedite the roundtrip.

OK; the patches look fine to me.  If that's what you're doing, I won't
apply them to my tree, to avoid duplication.

Paul.