Re: [PATCH 2/3] http: try standard proxy env vars when http.proxy config option is not set

Nelson Benitez Leon [off-list ref] writes:

On 03/14/2012 05:36 AM, Junio C Hamano wrote:

quoted

Are you sure $no_proxy is spelled in lowercase?  man curl(1) seems to
indicate otherwise.

Instead here[1] in section "Environment Variables" it's spelled lowercase,
and given that cURL reads $http_proxy only in lowercase I think it does
the same for $no_proxy.

Don't think, but read ;-).  Quoting from man curl(1):

	ENVIRONMENT

        The environment variables can be specified in lower case or upper
        case. The lower case version has precedence. http_proxy is an
        exception as it is only available in lower case.

On 03/14/2012 09:41 PM, Junio C Hamano wrote:

Nelson Benitez Leon [off-list ref] writes:

quoted

On 03/14/2012 05:36 AM, Junio C Hamano wrote:

quoted

Are you sure $no_proxy is spelled in lowercase?  man curl(1) seems to
indicate otherwise.

Instead here[1] in section "Environment Variables" it's spelled lowercase,
and given that cURL reads $http_proxy only in lowercase I think it does
the same for $no_proxy.

Don't think, but read ;-).  Quoting from man curl(1):

	ENVIRONMENT

        The environment variables can be specified in lower case or upper
        case. The lower case version has precedence. http_proxy is an
        exception as it is only available in lower case.

Ok, good advice nonetheless :-), so will send a new 1/5 patch that also
reads $NO_PROXY.