[PATCH V2] t0204: Removed TC emitting ISO-8859-1 from our UTF-8 *.mo files
From: Torsten Bögershausen <hidden>
Date: 2016-06-15 22:53:14
Subsystem:
the rest · Maintainer:
Linus Torvalds
Removed this test case: gettext: Emitting ISO-8859-1 from our UTF-8 *.mo files / Runes The removed test case tried to show UTF-8 encoded text in a ISO-8859-1 locale with code points that don't fit into ISO-8859-1. Some systems convert these code points into question marks, (that is what the test expects) while other don't support an ISO-8859-1 locale anymore and use UTF-8 anyway. Remove the text case as there is no reason to insist that the fall back behaviour is to convert code points out of range into question marks. Signed-off-by: Torsten Bögershausen <redacted> ---
This is insane.
[snip]
I do not see any reason to insist that their fallback behaviour must be to fill them with question marks. In other words, I simply do not see the point of this test and the original "pass runs of question" to begin with, and this patch makes things even worse.
Why not get rid of this single test that only tries to check the output for an impossible request? Ævar, am I missing something?
I don't think so. Better a good remove than a bad improve Junio, thanks for the replay, I tried to convert your comments into a commit message. t/t0204-gettext-reencode-sanity.sh | 14 -------------- 1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/t/t0204-gettext-reencode-sanity.sh b/t/t0204-gettext-reencode-sanity.sh
index 189af90..b0628a1 100755
--- a/t/t0204-gettext-reencode-sanity.sh
+++ b/t/t0204-gettext-reencode-sanity.sh@@ -26,20 +26,6 @@ test_expect_success GETTEXT_ISO_LOCALE 'gettext: Emitting ISO-8859-1 from our UT test_cmp expect actual ' -test_expect_success GETTEXT_ISO_LOCALE 'gettext: Emitting ISO-8859-1 from our UTF-8 *.mo files / Runes' ' - LANGUAGE=is LC_ALL="$is_IS_iso_locale" gettext "TEST: Old English Runes" >runes && - - if grep "^TEST: Old English Runes$" runes - then - say "Your system can not handle this complexity and returns the string as-is" - else - # Both Solaris and GNU libintl will return this stream of - # question marks, so it is s probably portable enough - printf "TILRAUN: ?? ???? ??? ?? ???? ?? ??? ????? ??????????? ??? ?? ????" >runes-expect && - test_cmp runes-expect runes - fi -' - test_expect_success GETTEXT_LOCALE 'gettext: Fetching a UTF-8 msgid -> UTF-8' ' printf "TILRAUN: ‚einfaldar‘ og „tvöfaldar“ gæsalappir" >expect && LANGUAGE=is LC_ALL="$is_IS_locale" gettext "TEST: ‘single’ and “double” quotes" >actual &&
--
1.7.9.rc2