Jakub Narebski [off-list ref] writes:
quoted
quoted
RPM build errors:
Installed (but unpackaged) file(s) found:
/usr/share/locale/is/LC_MESSAGES/git.mo
I think it should be simply ignored at least for now. I stopped touching
the rpm spec since August last year (the only reason I was running rpmbuild
was to install them on k.org), so I didn't notice.
So for the time being something like that would be an acceptable fix?
Except that the patch probably wants to go to git.spec.in, removing that
installation target would be a good local workaround for now.
I said "local workaround", meaning that I am not all that interested in
applying such a patch myself. Somebody who wants to do RPM needs to
decide what subpackage(s) it should go before we start accepting more po/
files, and at that time the workaround needs to be reverted.
And hopefully that should happen soonish ;-)
On Fri, 3 Feb 2012, Junio C Hamano wrote:
Jakub Narebski [off-list ref] writes:
quoted
quoted
quoted
RPM build errors:
Installed (but unpackaged) file(s) found:
/usr/share/locale/is/LC_MESSAGES/git.mo
I think it should be simply ignored at least for now. I stopped touching
the rpm spec since August last year (the only reason I was running rpmbuild
was to install them on k.org), so I didn't notice.
So for the time being something like that would be an acceptable fix?
Except that the patch probably wants to go to git.spec.in, removing that
installation target would be a good local workaround for now.
O.K., will do.
Anyway this change makes rpmbuild process complete.
I said "local workaround", meaning that I am not all that interested in
applying such a patch myself. Somebody who wants to do RPM needs to
decide what subpackage(s) it should go before we start accepting more po/
files, and at that time the workaround needs to be reverted.
And hopefully that should happen soonish ;-)
The git-i18n-Icelandic proposal for /usr/share/locale/is/LC_MESSAGES/git.mo
follow the KDE pattern (e.g. kde-i18n-Polish). This might be a place for
translated manpages and other documentation, if there is any.
On the other hand all translations for gitk are in gitk package
(as /usr/share/gitk/lib/msgs/*.msg, not /usr/share/locale/*/LC_MESSAGES/git.mo)
Same for git-gui.
--
Jakub Narebski
Poland
Currently building git RPM from tarball results in the following
error:
RPM build errors:
Installed (but unpackaged) file(s) found:
/usr/share/locale/is/LC_MESSAGES/git.mo
This is caused by the fact that localized messages do not have their
place in some RPM package. Let's postpone decision where they should
be put (be it git-i18n-Icelandic, or git-i18n, or git package itself)
for later by removing locale files at the end of install phase.
Signed-off-by: Jakub Narebski <redacted>
---
git.spec.in | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git.spec.in b/git.spec.in
index c562c62..b93df10 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -134,6 +134,7 @@ find $RPM_BUILD_ROOT -type f -name perllocal.pod -exec rm -f {} ';'
%else
rm -rf $RPM_BUILD_ROOT%{_mandir}
%endif
+rm -rf $RPM_BUILD_ROOT%{_datadir}/locale
mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/bash_completion.d
install -m 644 -T contrib/completion/git-completion.bash $RPM_BUILD_ROOT%{_sysconfdir}/bash_completion.d/git--
1.7.9