Re: [PATCH v3 1/4] completion: be nicer with zsh

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v3 1/4] completion: be nicer with zsh

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:55

Jonathan Nieder [off-list ref] writes:
Felipe Contreras wrote:
quoted
Felipe Contreras (4):
  completion: be nicer with zsh
Since I can't find this patch in the mail archive, I'll reply here.
Luckily the most important bit is above already.
Thanks for playing a mail-relay.  Except for the much more readable log
message you have here, the result matches what I have at 06357ef (modulo
test vs '[').  I'll replace what I queued.
I think I mentioned before that this subject line is what will appear
in the shortlog and the shortlog is all that some people will see of
the changelog, so it should include a self-contained description of
the impact of the patch.

However, clearly I did not say it clearly enough. :)  I guess it's
better to take a cue from storytellers and show rather than tell.
Very big thanks for this ;-)

Re: [PATCH v3 1/4] completion: be nicer with zsh

From: Felipe Contreras <hidden>
Date: 2016-06-15 22:52:55

On Thu, Feb 2, 2012 at 9:27 PM, Junio C Hamano [off-list ref] wrote:
Jonathan Nieder [off-list ref] writes:
quoted
However, clearly I did not say it clearly enough. :)  I guess it's
better to take a cue from storytellers and show rather than tell.
Very big thanks for this ;-)
Not a single comment regarding what I said? I don't see what's not
sensible about a commit message with this order:

 1) short description of the *purpose* of the patch
 2) Summary of the problem.
 3) Proposed solution
 4) Extra information, useful for future references, etc.

This ensures the most relevant information for most people is at the top.

-- 
Felipe Contreras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help