Felipe Contreras [off-list ref] writes:
In any case, there's no need for ad hominem arguments; there is a
problem when using zsh, that's a fact.
There was no ad-hominem argument at all.
Read your two lines I quoted "... the code is now actually understandable
(at least to me), while before it looked like voodoo", which was your
words. What does it tell the reader? The patch author (1) did not
understand existing code (voodoo) and (2) the change is a good thing as a
style/readability improvement.
I was saying that I did not want to see that in the justification, because
(2) is not true, while (1) may be.
The patch as-is is a good change that works around issues with zsh's POSIX
emulation, and that is sufficient-enough justification. IOW, we are in
agreement on the later half of your sentence.
On Mon, Jan 30, 2012 at 8:07 PM, Junio C Hamano [off-list ref] wrote:
Felipe Contreras [off-list ref] writes:
quoted
In any case, there's no need for ad hominem arguments; there is a
problem when using zsh, that's a fact.
There was no ad-hominem argument at all.
Read your two lines I quoted "... the code is now actually understandable
(at least to me), while before it looked like voodoo", which was your
words. What does it tell the reader? The patch author (1) did not
understand existing code (voodoo) and (2) the change is a good thing as a
style/readability improvement.
I disagree. Another possibility is that the code actually looked like
voodoo (it was obfuscated). You might disagree, but the fact that one
of the main editors (the most used?) doesn't even recognize the syntax
of this code I think is pretty telling.
I was saying that I did not want to see that in the justification, because
(2) is not true, while (1) may be.
That's not true: (2) might be true; at least it's debatable.
The patch as-is is a good change that works around issues with zsh's POSIX
emulation, and that is sufficient-enough justification. IOW, we are in
agreement on the later half of your sentence.
So, I shall just remove that part of the explanation?
--
Felipe Contreras