Re: [PATCH 1/6] t3040 (subprojects-basic): modernize style

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 1/6] t3040 (subprojects-basic): modernize style

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:35

Ramkumar Ramachandra [off-list ref] writes:
quoted
I suspect the above description, while it does describe your patch,
does not describe the _reason_ that the patch exists or that someone
would want to apply it.  Isn't it something more like:
[...]
Right, fixed.
Does the "fixed" mean "I fixed it locally; please expect to see it in the
next re-roll?"

Just a quick question, not asking you to always spell it that way.

Re: [PATCH 1/6] t3040 (subprojects-basic): modernize style

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:52:35

Hi Junio,

Junio C Hamano wrote:
Ramkumar Ramachandra [off-list ref] writes:
quoted
Right, fixed.
Does the "fixed" mean "I fixed it locally; please expect to see it in the
next re-roll?"
Yes, it means exactly that :)
I respond/ archive the review emails as soon as I fix the
corresponding issue locally -- it's the only way to make sure that I
don't miss anything (although I miss a few comments despite that).

-- Ram
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help