git reset --merge documentation improvments

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

git reset --merge documentation improvments

From: Philippe Vaucher <hidden>
Date: 2016-06-15 22:52:31

Hello,

The current documentation for --merge is:

"Resets the index [1] and updates the files in the working tree that
are different between <commit> and HEAD, but keeps those which are
different between the index [2] and working tree"

I think this is confusing, because [1] is the *after-reset* index and
[2] is the *before-reset* index. If you fail to realise this it looks
like this "resets index (so index is empty) and then updates worktree
but skip files staged from index" --> "but there's nothing staged, the
index was reset!"

I think a better sentence would be:

"Updates the files in the working tree that are different between
<commit> and HEAD, but keeps those which are different between the
index and working tree, and finally resets the index."

Or something along those lines.

Philippe

Re: git reset --merge documentation improvments

From: Vincent van Ravesteijn <hidden>
Date: 2016-06-15 22:52:31

Op 23-11-2011 9:31, Philippe Vaucher schreef:
Hello,

The current documentation for --merge is:

"Resets the index [1] and updates the files in the working tree that
are different between<commit>  and HEAD, but keeps those which are
different between the index [2] and working tree"

I think this is confusing, because [1] is the *after-reset* index and
[2] is the *before-reset* index.
You mean that you read that the *after-reset* index is reset ? They both 
refer to the *before-reset* index.
  If you fail to realise this it looks
like this "resets index (so index is empty) and then updates worktree
but skip files staged from index" -->  "but there's nothing staged, the
index was reset!"
The misunderstanding comes from the added "then".
I think a better sentence would be:

"Updates the files in the working tree that are different between
<commit>  and HEAD, but keeps those which are different between the
index and working tree, and finally resets the index."
There is nothing to update as long as the index is not reset.

Vincent

Re: git reset --merge documentation improvments

From: Philippe Vaucher <hidden>
Date: 2016-06-15 22:52:31

quoted
"Updates the files in the working tree that are different between
<commit>  and HEAD, but keeps those which are different between the
index and working tree, and finally resets the index."
There is nothing to update as long as the index is not reset.
Well then I simply don't understand what --merge does. Is it like
--keep but instead of failing when a file-to-be-overwritten has
changes it simply ignores the overwriting and continues?

Philippe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help