[PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

Subsystems: the rest

STALE3716d

4 messages, 3 authors, 2016-06-15 · open the first message on its own page

[PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

From: Ramsay Jones <hidden>
Date: 2016-06-15 22:52:19

Signed-off-by: Ramsay Jones <redacted>
---
 gitweb/Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/gitweb/Makefile b/gitweb/Makefile
index 1c85b5f..4191c6b 100644
--- a/gitweb/Makefile
+++ b/gitweb/Makefile
@@ -185,7 +185,9 @@ install: all
 ### Cleaning rules
 
 clean:
-	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
+	$(RM) gitweb.cgi static/gitweb.js \
+		static/gitweb.min.js static/gitweb.min.css \
+		GITWEB-BUILD-OPTIONS
 
 .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
 
-- 
1.7.7

Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

From: Drew Northup <hidden>
Date: 2016-06-15 22:52:19

On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
quoted hunk
Signed-off-by: Ramsay Jones <redacted>
---
 gitweb/Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/gitweb/Makefile b/gitweb/Makefile
index 1c85b5f..4191c6b 100644
--- a/gitweb/Makefile
+++ b/gitweb/Makefile
@@ -185,7 +185,9 @@ install: all
 ### Cleaning rules
 
 clean:
-	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
+	$(RM) gitweb.cgi static/gitweb.js \
+		static/gitweb.min.js static/gitweb.min.css \
+		GITWEB-BUILD-OPTIONS
 
 .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
 
Forgive me for sounding a bit numb, but what does this fix? I don't see
it in the commit message.

-- 
-Drew Northup
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59

Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:52:19

Drew Northup napisał:
On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
quoted
Signed-off-by: Ramsay Jones <redacted>
---
 gitweb/Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/gitweb/Makefile b/gitweb/Makefile
index 1c85b5f..4191c6b 100644
--- a/gitweb/Makefile
+++ b/gitweb/Makefile
@@ -185,7 +185,9 @@ install: all
 ### Cleaning rules
 
 clean:
-	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
+	$(RM) gitweb.cgi static/gitweb.js \
+		static/gitweb.min.js static/gitweb.min.css \
+		GITWEB-BUILD-OPTIONS
 
 .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
 
Forgive me for sounding a bit numb, but what does this fix? I don't see
it in the commit message.
gitweb.js is nowadays a generated file.  Though that bit should be
in commit message...

-- 
Jakub Narebski
Poland

Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

From: Ramsay Jones <hidden>
Date: 2016-06-15 22:52:20

Jakub Narebski wrote:
Drew Northup napisał:
quoted
On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
quoted
Signed-off-by: Ramsay Jones <redacted>
---
 gitweb/Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/gitweb/Makefile b/gitweb/Makefile
index 1c85b5f..4191c6b 100644
--- a/gitweb/Makefile
+++ b/gitweb/Makefile
@@ -185,7 +185,9 @@ install: all
 ### Cleaning rules
 
 clean:
-	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
+	$(RM) gitweb.cgi static/gitweb.js \
+		static/gitweb.min.js static/gitweb.min.css \
+		GITWEB-BUILD-OPTIONS
 
 .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
 
Forgive me for sounding a bit numb, but what does this fix? I don't see
it in the commit message.
gitweb.js is nowadays a generated file.  Though that bit should be
in commit message...
Yep, will do ...

ATB,
Ramsay Jones
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help