[PATCH] builtin/pack-objects.c: Fix a printf format compiler warning

Subsystems: the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] builtin/pack-objects.c: Fix a printf format compiler warning

From: Ramsay Jones <hidden>
Date: 2016-06-15 22:52:18

In particular, on systems that define uint32_t as an unsigned long,
gcc complains as follows:

        CC builtin/pack-objects.o
    pack-objects.c: In function `compute_write_order':
    pack-objects.c:600: warning: unsigned int format, uint32_t arg (arg 3)

In order to suppress the warning, we use the C99 format specifier
macro PRIu32.

Signed-off-by: Ramsay Jones <redacted>
---

Hi Dan,

If you need to re-roll your pack-objects series (dm/pack-objects-update
branch in pu), could you please squash this change into your final commit
0a8145bd (pack-objects: don't traverse objects unnecessarily, 18-10-2011).

If you don't need to re-roll, then I'm hoping Junio will notice and squash
this in before it hits next. ;-)

ATB,
Ramsay Jones

 builtin/pack-objects.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index 6db45fa..4bbd815 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -597,7 +597,7 @@ static struct object_entry **compute_write_order(void)
 	}
 
 	if (wo_end != nr_objects)
-		die("ordered %u objects, expected %u", wo_end, nr_objects);
+		die("ordered %u objects, expected %"PRIu32, wo_end, nr_objects);
 
 	return wo;
 }
-- 
1.7.7

Re: [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning

From: Dan McGee <hidden>
Date: 2016-06-15 22:52:18

On Wed, Oct 19, 2011 at 2:10 PM, Ramsay Jones
[off-list ref] wrote:
In particular, on systems that define uint32_t as an unsigned long,
gcc complains as follows:

       CC builtin/pack-objects.o
   pack-objects.c: In function `compute_write_order':
   pack-objects.c:600: warning: unsigned int format, uint32_t arg (arg 3)

In order to suppress the warning, we use the C99 format specifier
macro PRIu32.

Signed-off-by: Ramsay Jones <redacted>
---

Hi Dan,

If you need to re-roll your pack-objects series (dm/pack-objects-update
branch in pu), could you please squash this change into your final commit
0a8145bd (pack-objects: don't traverse objects unnecessarily, 18-10-2011).

If you don't need to re-roll, then I'm hoping Junio will notice and squash
this in before it hits next. ;-)
Sorry about that- fixed locally, and if I do need to resend them then
it will be fixed.

-Dan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help