Re: [PATCH] use test number as port number
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:17
Clemens Buchacher [off-list ref] writes:
quoted hunk
Test 5550 was apparently using the default port number by mistake. Signed-off-by: Clemens Buchacher <redacted> --- On Sun, Oct 16, 2011 at 10:01:03PM -0400, Jeff King wrote:quoted
LIB_DAEMON_PORT=${LIB_DAEMON_PORT-'5570'}Thanks, I missed that. Clemens t/t5550-http-fetch.sh | 2 +- t/t5570-git-daemon.sh | 1 + 2 files changed, 2 insertions(+), 1 deletions(-)diff --git a/t/t5550-http-fetch.sh b/t/t5550-http-fetch.sh index a1883ca..8a77750 100755 --- a/t/t5550-http-fetch.sh +++ b/t/t5550-http-fetch.sh@@ -8,8 +8,8 @@ if test -n "$NO_CURL"; then test_done fi -. "$TEST_DIRECTORY"/lib-httpd.sh LIB_HTTPD_PORT=${LIB_HTTPD_PORT-'5550'} +. "$TEST_DIRECTORY"/lib-httpd.sh start_httpd
Good eyes. This is the only one in the 55xx series that gets the order wrong. I'll drop the patch to 5570 for now as that should be done in the change that is still not in 'next' that adds 5570. I've fixed and queued the previous one as aa0b028 (daemon: add tests, 2011-10-17); does that look good enough?
quoted hunk
diff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh index e6482eb..a92d996 100755 --- a/t/t5570-git-daemon.sh +++ b/t/t5570-git-daemon.sh@@ -3,6 +3,7 @@ test_description='test fetching over git protocol' . ./test-lib.sh +LIB_DAEMON_PORT=${LIB_DAEMON_PORT-'5570'} . "$TEST_DIRECTORY"/lib-daemon.sh start_daemon