Re: [PATCH/RFC] gitweb: add the ability to show side-by-side diff on commitdiff.

Kato Kazuyoshi [off-list ref] writes:

Probably like:

- format_diff_line returns a class with an line.
- remove trailing space from the class.
- add side-by-side feature and CSS.
- add form.

Thank you for your correction!

My wording came out a bit too strong; I didn't mean to "correct" anything.

I think a better organization would be

 [1/2] change code so that $diff_class does not have leading SP
       optionally catch a case where $diff_class stays empty as an error?

 [2/2] add side-by-side feature, which would involve:
  - making format_diff_line() to return $diff_class separately;
  - necessary addition of CSS;
  - addition of form to trigger the feature.

I do not think splitting the second patch into pieces smaller than that
makes sense.

Thanks.
 
 

On Mon, Oct 17, 2011 at 10:51 AM, Junio C Hamano [off-list ref] wrote:

I think a better organization would be

 [1/2] change code so that $diff_class does not have leading SP
      optionally catch a case where $diff_class stays empty as an error?

I think we don't have to treat empty $diff_class as an error because
$diff_class will be an empty when $line is around modification
(ex. foo or quux).

  foo
- bar
+ baz
  quuz

And class attributes are CDATA. "diff[SP]" and "diff" have same
meanings.
http://www.w3.org/TR/html401/struct/global.html#h-7.5.2
http://www.w3.org/TR/html401/types.html#type-cdata

-- 
Kato Kazuyoshi