Re: [PATCH] gitweb: Fix links to lines in blobs when javascript-actions are enabled

Peter Stuge [off-list ref] writes:

Some javascript code will run in the browser onLoad and signals back to
gitweb that the browser can actually do javascript.

The code adds [?;]js=1 into the URL of all links on the page. The code
always added [?;]js=1 to the end of links, which is wrong when links
contain a URI fragment, such as links directly to a line in a blob:
..?p=repo.git;a=blob;f=file#l123

In this case, [?;]js=1 must be added before the hashmark.

Signed-off-by: Peter Stuge <redacted>

Nicely done. You forgot to mention another bug you fixed (see Jakub's
sample in the thread), so I'll amend in a few sentences to describe it as
well.

Thanks.

Junio C Hamano wrote:

Nicely done.

Thanks.

You forgot to mention another bug you fixed

Well.. I'm not sure that it is worth mentioning, since it may never
actually have been triggered by the way fixLinks() works.

I'll amend in a few sentences to describe it as well.

Go for it.


//Peter