So I wouldn't ever have noticed on my own, but now that I've tried
github for the kernel, somebody else reported that the downloaded zip
file (seriously? the kernel as a zip file?) is corrupt.
And it doesn't really seem to be a github issue. I can re-create it
with a simple
git archive --format=zip HEAD -o ../kernel.zip
on my kernel repository: the end result does not unzip correctly:
mkdir temp-directory
cd temp-directory
unzip kernel.zip
...
inflating: virt/kvm/iommu.c
inflating: virt/kvm/irq_comm.c
inflating: virt/kvm/kvm_main.c
finishing deferred symbolic links:
arch/microblaze/boot/dts/system.dts -> ../../platform/generic/system.dts
drivers/scsi/aic94xx/aic94xx_reg.h -> /*^J * Aic94xx SAS/SATA
driver hardware registers definitions.[ rest of the file ]
symlink error: File name too long
iow, for some reason that "drivers/scsi/aic94xx/aic94xx_reg.h" file
seems to have been encoded as a symlink.
Anybody seen this?
Linus
On Sat, Sep 10, 2011 at 09:58:08PM -0700, Linus Torvalds wrote:
So I wouldn't ever have noticed on my own, but now that I've tried
github for the kernel, somebody else reported that the downloaded zip
file (seriously? the kernel as a zip file?) is corrupt.
And it doesn't really seem to be a github issue. I can re-create it
with a simple
git archive --format=zip HEAD -o ../kernel.zip
on my kernel repository: the end result does not unzip correctly:
Hmm. I can easily replicate the problem here, but interestingly it does
not happen with sub-trees like:
git archive --format=zip HEAD:drivers -o ../kernel.zip
Going back in history, I can replicate it with René's 62cdce1
(git-archive --format=zip: add symlink support, 2006-10-07). So there's
nothing to bisect.
Cc'ing René.
-Peff
On Sun, Sep 11, 2011 at 02:22:06AM -0400, Jeff King wrote:
Hmm. I can easily replicate the problem here, but interestingly it does
not happen with sub-trees like:
git archive --format=zip HEAD:drivers -o ../kernel.zip
Going back in history, I can replicate it with René's 62cdce1
(git-archive --format=zip: add symlink support, 2006-10-07). So there's
nothing to bisect.
Weirder still. I get roughly the same output as you:
finishing deferred symbolic links:
arch/microblaze/boot/dts/system.dts -> ../../platform/generic/system.dts
drivers/scsi/aic94xx/aic94xx_reg.h -> /*^J * Aic94xx SAS/SATA driver...
But looking at the generated file with zipinfo, I see:
$ zipinfo kernel.zip
...
lrwxrwxrwx 2.3 unx 33 b- stor 11-Aug-25 14:02 arch/microblaze/boot/dts/system.dts
...
-rw---- 0.0 fat 10470 b- defN 11-Aug-25 14:02 drivers/scsi/aic94xx/aic94xx_reg.h
IOW, the zip file looks right. I wonder if this is actually a bug in
"unzip".
-Peff