Re: [PATCH] am: format is in $patch_format, not parse_patch

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] am: format is in $patch_format, not parse_patch

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:56

Giuseppe Bilotta [off-list ref] writes:
The error message given when the patch format was not recognized was
wrong, since the variable checked was $parse_patch rather than
$patch_format. Fix by checking the non-emptyness of the correct
variable.
Thanks for a fix to a problem that is from more than two years ago ;-)

Re: [PATCH] am: format is in $patch_format, not parse_patch

From: Giuseppe Bilotta <hidden>
Date: 2016-06-15 22:51:56

On Mon, Aug 29, 2011 at 6:12 PM, Junio C Hamano [off-list ref] wrote:
Giuseppe Bilotta [off-list ref] writes:
quoted
The error message given when the patch format was not recognized was
wrong, since the variable checked was $parse_patch rather than
$patch_format. Fix by checking the non-emptyness of the correct
variable.
Thanks for a fix to a problem that is from more than two years ago ;-)
You're welcome. I'm actually surprised that wasn't something _I_ did
by mistake ;-)

That part of the code isn't being stressed too much. I've just found
another issue. Patch coming, plus another enhancement.

-- 
Giuseppe "Oblomov" Bilotta
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help