Re: [PATCH] git-send-email: Add AUTH LOGIN support

Joe Perches [off-list ref] writes:

On Fri, 2011-08-05 at 22:21 -0700, Joe Perches wrote:

quoted

I needed something now.

You are right but I believe it would take too long
to get updates to Net::SMTP in place. Doing this
admitted ugliness in git-send-email works for me and
seems to me to be appropriate for now.

I looked, there isn't a method to force a particular
AUTH type documented.  I also didn't care to rewrite
Net::SMTP right now.  This "works for me"...

Good for you ;-)

quoted

quoted

It probably is not as simple as installing Authen::SASL::*::LOGIN, but
still...

I think my patch should be applied until Net::SMTP is updated.

And you already have applied to your copy, no?

I understand you needed something _now_ and that is why you wrote it, but
the thing is, I don't need the ugliness nor an ability to force AUTH LOGIN
right now, so I do not necessarily agree with you that the patch _should_
be applied to my tree.

On Fri, 2011-08-19 at 16:09 -0700, Junio C Hamano wrote:

Joe Perches [off-list ref] writes:

quoted

I think my patch should be applied until Net::SMTP is updated.

And you already have applied to your copy, no?

True.

I do not necessarily agree with you that the patch _should_
be applied to my tree.

Your choice.  It does make tracking git development
a bit of a pain for me though.

There doesn't seem to be anything like a patchwork queue
for git development to check status of patches.

I've sent a couple of other patches to git-send-email.

http://marc.info/?l=git&m=131190328311281&w=2
http://marc.info/?l=git&m=131131975804893&w=2

Any comments or plans to ack/nack those?