Re: [PATCH 3/5] setup_revisions: remember whether a ref was positive or not
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:46
Sverre Rabbelier [off-list ref] writes:
Nobody needs the stuff you mentioned right now.
Wrong. "diff ^C A B" is a bug, isn't it? And that is a bug in the current code.
quoted
I would be reluctant to accept a myopic hack that is only good for one caller and that needs to be ripped out and re-done, especially when we already know other issues that can be solved cleanly if you go a little further in the initial round.While I understand this reluctance, remember that this "one caller" is required to fix a bug in the current code.